<p> Attention is currently required from: N A. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/18829">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829?tab=comments">Patch Set #1:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Look at the line diff counts for your patch set. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">configure attributed to most of these changes</p><p style="white-space: pre-wrap; word-wrap: break-word;">Reffering to https://wiki.asterisk.org/wiki/display/AST/Build+System+Architecture</p><p style="white-space: pre-wrap; word-wrap: break-word;">it says it should be included as quoted below, is this not the case?</p><p style="white-space: pre-wrap; word-wrap: break-word;">run ./bootstrap.sh to regenerate ./configure and ./include/asterisk/autoconfig.h.in (both of which must be checked in if submitting a patch).</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829?tab=comments">Patch Set #2:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">I'm not changing 10000 lines, but how do I exclude files in the automatic upload done by 'git review'.</p><p style="white-space: pre-wrap; word-wrap: break-word;">It seem like there are 2 I don't want included.<br># modified: menuselect/configure<br># modified: configure</p><p style="white-space: pre-wrap; word-wrap: break-word;">Regarding the testing with asterisk 16, this code is deployed on a production box running 16.</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">But I also have a test box running master which I am submitting these reviews from.<br> <br>Alec</pre></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18829">change 18829</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18829"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ifdf4d33d2a2a5fd044fac13b201c7437de34ba6a </div>
<div style="display:none"> Gerrit-Change-Number: 18829 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Alec Davis <alec@bdt.co.nz> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Attention: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 22 Jul 2022 00:15:51 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Comment-In-Reply-To: Alec Davis <alec@bdt.co.nz> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>