<p> Attention is currently required from: Joshua Colp. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/18614">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_prometheus.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18614/comment/086bb1ae_5271fa9d">Patch Set #1, Line 981:</a> <code style="font-family:monospace,monospace"> if (pjsip_outbound_registration_metrics_init())</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I don't think this is truly sufficient. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I've tried to use an optional API, but faced a warning:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">```<br>prometheus/pjsip_outbound_registrations.c:342:5: warning: no previous prototype for function '__pjsip_outbound_registration_metrics_init' [-Wmissing-prototypes]<br>int AST_OPTIONAL_API_NAME(pjsip_outbound_registration_metrics_init)(void)<br> ^<br>/wrkdirs/usr/ports/net/asterisk18/work/asterisk-18.13.0/include/asterisk/optional_api.h:175:37: note: expanded from macro 'AST_OPTIONAL_API_NAME'<br>#define AST_OPTIONAL_API_NAME(name) __##name<br> ^<br><scratch space>:74:1: note: expanded from here<br>__pjsip_outbound_registration_metrics_init<br>^<br>prometheus/pjsip_outbound_registrations.c:342:1: note: declare 'static' if the function is not intended to be used outside of this translation unit<br>int AST_OPTIONAL_API_NAME(pjsip_outbound_registration_metrics_init)(void)<br>^<br>static <br>1 warning generated.<br>```</pre><p style="white-space: pre-wrap; word-wrap: break-word;">Can you help me to avoid the warning?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18614">change 18614</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18614"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 18 </div>
<div style="display:none"> Gerrit-Change-Id: Ia34f1684d984e821fbdd4de8911f930337703666 </div>
<div style="display:none"> Gerrit-Change-Number: 18614 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Boris P. Korzun <drtr0jan@yandex.ru> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Mark Petersen <asterisk.org@zombie.dk> </div>
<div style="display:none"> Gerrit-Reviewer: Mark Petersen <bugs.digium.com@zombie.dk> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 24 Jun 2022 08:45:07 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>