<p>Sean Bright has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/c/testsuite/+/18546">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">asttest: Be explicit about the signedness of chars.<br><br>On arm64, chars are unsigned by default - as opposed to x86 where they<br>are signed by default. This causes problems when trying to compare<br>chars with negative numbers so be explicit where it matters.<br><br>Change-Id: I3f85d9252ae39227d82d5efaf6e6874cdfa71138<br>---<br>M asttest/asttest.c<br>M asttest/tools/mkstring.c<br>2 files changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/46/18546/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/asttest/asttest.c b/asttest/asttest.c</span><br><span>index 4375fa6..152d84a 100644</span><br><span>--- a/asttest/asttest.c</span><br><span>+++ b/asttest/asttest.c</span><br><span>@@ -73,7 +73,7 @@</span><br><span>  * @return 0 success</span><br><span>  */</span><br><span> int parse_cmdline(int argc, char *argv[], struct asttest_opts *opts) {</span><br><span style="color: hsl(0, 100%, 40%);">-        char c;</span><br><span style="color: hsl(120, 100%, 40%);">+       signed char c;</span><br><span>       memset(opts, 0, sizeof(struct asttest_opts));</span><br><span> </span><br><span>    /* set some default options */</span><br><span>diff --git a/asttest/tools/mkstring.c b/asttest/tools/mkstring.c</span><br><span>index 670477b..27774e0 100644</span><br><span>--- a/asttest/tools/mkstring.c</span><br><span>+++ b/asttest/tools/mkstring.c</span><br><span>@@ -66,7 +66,7 @@</span><br><span> }</span><br><span> </span><br><span> int parse_cmdline(int argc, char *argv[], struct mkstring_options *opts) {</span><br><span style="color: hsl(0, 100%, 40%);">-  char c;</span><br><span style="color: hsl(120, 100%, 40%);">+       signed char c;</span><br><span>       int i;</span><br><span>       while ((c = getopt(argc, argv, "n:o:")) != -1) {</span><br><span>           switch (c) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/testsuite/+/18546">change 18546</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/testsuite/+/18546"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: 19 </div>
<div style="display:none"> Gerrit-Change-Id: I3f85d9252ae39227d82d5efaf6e6874cdfa71138 </div>
<div style="display:none"> Gerrit-Change-Number: 18546 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>