<p> Attention is currently required from: Kevin Harwell. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/18362">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File channels/chan_dahdi.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18362/comment/ceb83f6c_fd53fa99">Patch Set #1, Line 195:</a> <code style="font-family:monospace,monospace">                     <para>However, when read, the function will always return 0 or 1.</para></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">It seems "idle" and "reverse" are just synonyms for "0" and "1", correct?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Yup!</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18362/comment/30b75b0b_ff2e92c1">Patch Set #1, Line 2675:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">      int res;<br>      struct dahdi_params dahdip;<br>   struct dahdi_pvt *pvt;<br><br>      if (strcasecmp(ast_channel_tech(chan)->type, "DAHDI")) {<br>         ast_log(LOG_WARNING, "%s is not a DAHDI channel\n", ast_channel_name(chan));<br>                return -1;<br>    }<br><br>   memset(&dahdip, 0, sizeof(dahdip));<br>       res = ioctl(ast_channel_fd(chan, 0), DAHDI_GET_PARAMS, &dahdip);<br><br>        if (res) {<br>            ast_log(LOG_WARNING, "Unable to get parameters of %s: %s\n", ast_channel_name(chan), strerror(errno));<br>              return -1;<br>    }<br>     if (!(dahdip.sigtype & __DAHDI_SIG_FXO)) {<br>                ast_log(LOG_WARNING, "%s is not an FXS Channel\n", ast_channel_name(chan));<br>         return -1;<br>    }<br><br>   pvt = ast_channel_tech_pvt(chan);<br>     if (!dahdi_analog_lib_handles(pvt->sig, 0, 0)) {<br>           ast_log(LOG_WARNING, "Channel signalling is not analog");<br>           return -1;<br>    }<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This code looks duped below. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18362">change 18362</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18362"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If6f50998f723e4484bf68e2473f5cedfeaf9b8f1 </div>
<div style="display:none"> Gerrit-Change-Number: 18362 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-CC: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Attention: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 13 May 2022 18:43:00 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>