<p> Attention is currently required from: Stanislav Abramenkov, George Joseph, Philip Prindeville. </p>
<p>Patch set 10:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/18534">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_crypto.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18534/comment/aeb481ad_223b55ae">Patch Set #10, Line 38:</a> <code style="font-family:monospace,monospace">#define OPENSSL_SUPPRESS_DEPRECATED 1</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">With this line removed, Asterisk builds without warning for me against both OpenSSL 1.1.1f and OpenSSL 3.0.2</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18534/comment/c3626e0e_56b44a46">Patch Set #10, Line 40:</a> <code style="font-family:monospace,monospace">#include <openssl/aes.h>            /* for AES_decrypt, AES_encrypt, AES_set... */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This #include is no longer needed</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18534/comment/ef5e4d4c_56e37ac7">Patch Set #10, Line 42:</a> <code style="font-family:monospace,monospace">#include <openssl/ssl.h>            /* for NID_sha1, RSA */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This #include is no longer needed</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18534/comment/78960cb4_3160b91b">Patch Set #10, Line 44:</a> <code style="font-family:monospace,monospace">#include <openssl/sha.h>            /* for SHA1 */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This #include is no longer needed</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18534">change 18534</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18534"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5c738756de75fd27ebad54be144c0ac6193f21b2 </div>
<div style="display:none"> Gerrit-Change-Number: 18534 </div>
<div style="display:none"> Gerrit-PatchSet: 10 </div>
<div style="display:none"> Gerrit-Owner: Philip Prindeville <philipp@redfish-solutions.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-CC: Stanislav Abramenkov <stas.abramenkov@gmail.com> </div>
<div style="display:none"> Gerrit-Attention: Stanislav Abramenkov <stas.abramenkov@gmail.com> </div>
<div style="display:none"> Gerrit-Attention: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Attention: Philip Prindeville <philipp@redfish-solutions.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 12 May 2022 14:04:14 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>