<p> Attention is currently required from: Moritz Fain. </p>
<p>Patch set 6:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/18413">View Change</a></p><p>7 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18413?tab=comments">Patch Set #6:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">This need an CHANGES entry. Please see the following for more information:</p><p style="white-space: pre-wrap; word-wrap: break-word;">https://wiki.asterisk.org/wiki/display/AST/CHANGES+and+UPGRADE.txt</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File channels/chan_pjsip.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18413/comment/df0fe31c_f2bf070e">Patch Set #6, Line 575:</a> <code style="font-family:monospace,monospace"> ast_channel_snapshot_invalidate_segment(chan, AST_CHANNEL_SNAPSHOT_INVALIDATE_BASE);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I wonder if this should moved into the ast_channel_tech_pvt_set call itself. Putting it here means it won't invalidate for other channel drivers.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18413/comment/592945b7_bd32be23">Patch Set #6, Line 1277:</a> <code style="font-family:monospace,monospace"> if (!channel || !uniqueid) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Is it possible for channel to be NULL here?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File include/asterisk/stasis_channels.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18413/comment/f9187770_06c56a67">Patch Set #6, Line 108:</a> <code style="font-family:monospace,monospace"> AST_STRING_FIELD(pvt_uniqueid); /*!< Channel drivers unique id */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Adding the field in this way breaks ABI compatibility. Declare it instead at the end of the struct using the AST_STRING_FIELD_EXTENDED(pvt_uniqueid);</p><p style="white-space: pre-wrap; word-wrap: break-word;">See stringfields.h for more info</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File main/stasis_channels.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18413/comment/112c2af8_0ad253d3">Patch Set #6, Line 287:</a> <code style="font-family:monospace,monospace"> ast_string_field_set(snapshot, pvt_uniqueid, ast_strdupa(ast_channel_tech(chan)->get_pvt_uniqueid(chan)));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">There should be no reason to duplicate the string here before passing it into "set", so should be okay to remove that call.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18413/comment/23fb0ae7_14a86c7d">Patch Set #6, Line 289:</a> <code style="font-family:monospace,monospace"> ast_string_field_set(snapshot, pvt_uniqueid, ast_channel_uniqueid(chan));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'm torn having it default to the channel's 'uniqueid'. I kinda lean toward if one is not specified then just set it to an empty string as they do kind of represent two separate things. Thoughts?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File tests/test_stasis_channels.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18413/comment/847729c3_98c0e4ae">Patch Set #6, Line 287:</a> <code style="font-family:monospace,monospace"> "pvt_id", ast_channel_uniqueid(chan),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">If it's changed to default to an empty string (see previous comment) the test will also need updating.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18413">change 18413</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18413"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7cc6e7a9d29efe74bc27811d788dac20fe559b87 </div>
<div style="display:none"> Gerrit-Change-Number: 18413 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: Moritz Fain <moritz@fain.io> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Attention: Moritz Fain <moritz@fain.io> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 26 Apr 2022 20:31:51 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>