<p> Attention is currently required from: N A, José Lopes. </p>
<p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/18367">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18367/comment/d3f187e3_16a842e2">Patch Set #3, Line 7:</a> <code style="font-family:monospace,monospace">res_pjsip_header_funcs: Add functions PJSIP_REPLY_HEADER and PJSIP_REPLY_HEADERS</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">In SIP this is called a response, not a reply. I think it should be renamed to be consistent with that SIP term.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18367?tab=comments">Patch Set #3:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">This also needs a CHANGES entry[1].</p><p style="white-space: pre-wrap; word-wrap: break-word;">[1] https://wiki.asterisk.org/wiki/display/AST/CHANGES+and+UPGRADE.txt</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_pjsip_reply_header_funcs.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18367/comment/b91076ad_21dae230">Patch Set #3, Line 111:</a> <code style="font-family:monospace,monospace">                  INVITE reply message. Multiple headers with the same name are included in the list only once.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">What happens if there are multiple responses? The behavior should be documented</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18367/comment/eefc8c90_10348ef5">Patch Set #3, Line 138:</a> <code style="font-family:monospace,monospace">/*! \brief Data structure used for ast_sip_push_task_wait_serializer  */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This duplicates a lot of the code from res_pjsip_header_funcs, I think it should just be part of that module.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18367/comment/99fed8eb_f610a9c2">Patch Set #3, Line 184:</a> <code style="font-family:monospace,monospace"> if (session->inv_session->state <= PJSIP_INV_STATE_EARLY) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Document why PJSIP_INV_STATE_EARLY</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18367">change 18367</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18367"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I264a610a9333359297a0825feb29a1bb4f4ad144 </div>
<div style="display:none"> Gerrit-Change-Number: 18367 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: José Lopes <jose.lopes@nfon.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Attention: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Attention: José Lopes <jose.lopes@nfon.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 20 Apr 2022 12:52:29 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>