<p> Attention is currently required from: Kevin Harwell. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/17940">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File apps/app_queue.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17940/comment/3e7144b6_a5b17062">Patch Set #4, Line 205:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> <para>Custom music on hold class to use, which will override the<br> music on hold class configured in <filename>queues.conf</filename>,<br> if specified.</para><br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">If there is an order precedence between the channel variable and "m" option that should be documente […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Good point. I actually never use CHANNEL(musicclass) and this showed me why - CHANNEL(musicclass) takes precedence over the m option, which is very non-intuitive. I don't think most users would realize that.<br>If nothing else, this would let them know NOT to use CHANNEL (or at least clear it first)</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File configs/samples/queues.conf.sample:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17940/comment/a0ee825b_09f273f8">Patch Set #4, Line 67:</a> <code style="font-family:monospace,monospace">; using the m option when calling the Queue application or if set</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Is there a precedence here between channel and "m" option? Like "m" overrides channel variable, whic […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Yup, same as before, I've made that clearer here.<br>I think the way it actually works currently is a bit silly, but that's an issue for another day...</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/17940">change 17940</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/17940"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie25a48569cf8755c305c9438b1ed292c3adcf8d7 </div>
<div style="display:none"> Gerrit-Change-Number: 17940 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Attention: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 29 Mar 2022 21:33:38 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>