<p>George Joseph has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/18276">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Makefile:  Disable XML doc validation<br><br>make_xml_documentation was being called with the --validate<br>flag set when it shouldn't have been.  This was causing<br>build failures if neither xmllint nor xmlstarlet were installed.<br>The correct behavior is to simply print a message that either<br>one of those tools should be installed for validation and<br>continue with the build.<br><br>ASTERISK-29988<br><br>Change-Id: Idc6c44114e7dd3fadae183a4e22f4fdba0b8a645<br>---<br>M Makefile<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/76/18276/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Makefile b/Makefile</span><br><span>index bb8cdd0..2f6a66e 100644</span><br><span>--- a/Makefile</span><br><span>+++ b/Makefile</span><br><span>@@ -480,7 +480,7 @@</span><br><span> # core-en_US.xml is the normal documentation created with asterisk builds.</span><br><span> doc/core-en_US.xml: makeopts .lastclean $(XML_core_en_US)</span><br><span>         @build_tools/make_xml_documentation --command=create_xml --source-tree=. --mod-subdirs="$(DOC_MOD_SUBDIRS)" \</span><br><span style="color: hsl(0, 100%, 40%);">-         --with-moduleinfo --validate --output-file=$@</span><br><span style="color: hsl(120, 100%, 40%);">+         --with-moduleinfo --output-file=$@</span><br><span> </span><br><span> # The full-en_US.xml target is only called by the wiki documentation generation process</span><br><span> # and does special post-processing in preparation for uploading to the wiki.</span><br><span>@@ -492,7 +492,7 @@</span><br><span>      @echo "--------------------------------------------------------------------------"</span><br><span> else</span><br><span>         @build_tools/make_xml_documentation --command=create_xml --source-tree=. --mod-subdirs="$(DOC_MOD_SUBDIRS)" \</span><br><span style="color: hsl(0, 100%, 40%);">-         --for-wiki --validate --output-file=$@ --core-output-file=./doc/core-en_US.xml</span><br><span style="color: hsl(120, 100%, 40%);">+                --for-wiki --output-file=$@ --core-output-file=./doc/core-en_US.xml</span><br><span> endif</span><br><span> </span><br><span> validate-docs: doc/core-en_US.xml</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18276">change 18276</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18276"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 19 </div>
<div style="display:none"> Gerrit-Change-Id: Idc6c44114e7dd3fadae183a4e22f4fdba0b8a645 </div>
<div style="display:none"> Gerrit-Change-Number: 18276 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>