<p> Attention is currently required from: Boris P. Korzun. </p>
<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/18071">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_pjsip_sdp_rtp.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18071/comment/224e7d32_a88785df">Patch Set #1, Line 124:</a> <code style="font-family:monospace,monospace"> timeout = ast_rtp_instance_get_timeout(rtp);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">timeout is used twice later […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">You retrieve the value of timeout, and then do this check:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> if (ast_channel_state(chan) != AST_STATE_UP || !ast_sockaddr_isnull(&session_media->direct_media_addr)) {</pre><p style="white-space: pre-wrap; word-wrap: break-word;">That code block doesn't use timeout. You can therefore move the timeout retrieve to after the if, to before it is actually used.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18071/comment/54db4328_3f14db00">Patch Set #1, Line 129:</a> <code style="font-family:monospace,monospace"> ast_rtp_instance_set_last_rx(rtp, now);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Done</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">The indentation of this is not correct</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18071/comment/9ea1c065_799d86d8">Patch Set #1, Line 131:</a> <code style="font-family:monospace,monospace"> return timeout * 500; /* recheck after half timeout */</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Avoiding possible races and faster reacting to cases while there is no a RTP at all.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Comment this with the code</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18071">change 18071</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18071"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I07326d5b9c40f25db717fd6075f6f3a8d77279eb </div>
<div style="display:none"> Gerrit-Change-Number: 18071 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Boris P. Korzun <drtr0jan@yandex.ru> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Boris P. Korzun <drtr0jan@yandex.ru> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 10 Mar 2022 12:06:56 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Comment-In-Reply-To: Boris P. Korzun <drtr0jan@yandex.ru> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>