<p> Attention is currently required from: Joshua Colp. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/18071">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_pjsip_sdp_rtp.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18071/comment/dc1728cb_6b9ca80c">Patch Set #1, Line 124:</a> <code style="font-family:monospace,monospace"> timeout = ast_rtp_instance_get_timeout(rtp);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">timeout doesn't need to be retrieved until it is actually used, after the AST_STATE_UP and direct me […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">timeout is used twice later<br>Please explain, how to do it better?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18071/comment/b94d20c0_f8eb0e27">Patch Set #1, Line 126:</a> <code style="font-family:monospace,monospace"> /* If the channel is not in UP state return for later check. */</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Multi-line comments use: […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18071/comment/6f8db96c_d1b5f6d8">Patch Set #1, Line 129:</a> <code style="font-family:monospace,monospace"> ast_rtp_instance_set_last_rx(rtp, now);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Add a comment of why this is being done</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18071/comment/255f0795_2d99cf87">Patch Set #1, Line 131:</a> <code style="font-family:monospace,monospace"> return timeout * 500; /* recheck after half timeout */</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Why a half timeout?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Avoiding possible races and faster reacting to cases while there is no a RTP at all.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18071/comment/d78cbd3d_a5f31305">Patch Set #1, Line 2145:</a> <code style="font-family:monospace,monospace"> session_media->timeout_sched_id = ast_sched_add_variable(sched, 500, rtp_check_timeout,</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Why the change here?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">For avoiding code duplication and planning next timeout check in the function, instead apply_negotiated_sdp_stream().</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18071">change 18071</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18071"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I07326d5b9c40f25db717fd6075f6f3a8d77279eb </div>
<div style="display:none"> Gerrit-Change-Number: 18071 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Boris P. Korzun <drtr0jan@yandex.ru> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 03 Mar 2022 16:18:01 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>