<p>Friendly Automation <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/18035">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  Kevin Harwell: Looks good to me, approved
  Friendly Automation: Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">app_mp3: Document and warn about HTTPS incompatibility.<br><br>mpg123 doesn't support HTTPS, but the MP3Player application<br>doesn't document this or warn the user about this. HTTPS<br>streams have become more common nowadays and users could<br>reasonably try to play them without being aware they should<br>use the HTTP stream instead.<br><br>This adds documentation to note this limitation. It also<br>throws a warning if users try to use the HTTPS stream to<br>tell them to use the HTTP stream instead.<br><br>ASTERISK-29900 #close<br><br>Change-Id: Ie3b029be5258c5a701f71ed3b1a7a80d1e03b827<br>---<br>M apps/app_mp3.c<br>1 file changed, 5 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/apps/app_mp3.c b/apps/app_mp3.c</span><br><span>index 5d2fc88..9bc23c0 100644</span><br><span>--- a/apps/app_mp3.c</span><br><span>+++ b/apps/app_mp3.c</span><br><span>@@ -64,8 +64,9 @@</span><br><span>             </syntax></span><br><span>              <description></span><br><span>                  <para>Executes mpg123 to play the given location, which typically would be a mp3 filename</span><br><span style="color: hsl(0, 100%, 40%);">-                 or m3u playlist filename or a URL. Please read http://en.wikipedia.org/wiki/M3U</span><br><span style="color: hsl(120, 100%, 40%);">+                       or m3u playlist filename or a URL. Please read https://en.wikipedia.org/wiki/M3U</span><br><span>                     to see what the M3U playlist file format is like.</para></span><br><span style="color: hsl(120, 100%, 40%);">+                        <para>Note that mpg123 does not support HTTPS, so use HTTP for web streams.</para></span><br><span>                       <para>User can exit by pressing any key on the dialpad, or by hanging up.</para></span><br><span>                         <example title="Play an MP3 playlist"></span><br><span>                       exten => 1234,1,MP3Player(/var/lib/asterisk/playlist.m3u)</span><br><span>@@ -251,6 +252,9 @@</span><br><span>                           } else {</span><br><span>                                     ast_debug(1, "No more mp3\n");</span><br><span>                                     if (!startedmp3) { /* we couldn't do anything, which means this stream doesn't work */</span><br><span style="color: hsl(120, 100%, 40%);">+                                                if (!strncasecmp(data, "https://", 8)) {</span><br><span style="color: hsl(120, 100%, 40%);">+                                                    ast_log(LOG_WARNING, "%s() does not support HTTPS streams. Use HTTP instead.\n", app);</span><br><span style="color: hsl(120, 100%, 40%);">+                                              }</span><br><span>                                            ast_log(LOG_WARNING, "MP3 stream '%s' is broken or nonexistent\n", data);</span><br><span>                                  }</span><br><span>                                    res = 0;</span><br><span></span><br></pre><div style="white-space:pre-wrap"></div><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18035">change 18035</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18035"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: Ie3b029be5258c5a701f71ed3b1a7a80d1e03b827 </div>
<div style="display:none"> Gerrit-Change-Number: 18035 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>