<p> Attention is currently required from: Michael Bradeen, Sean Bright. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/18014">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18014?tab=comments">Patch Set #1:</a> </p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">My code review was removed. Reiterating so it doesn’t get missed:</p><p style="white-space: pre-wrap; word-wrap: break-word;">It would go a long way in terms of legibility if we moved the logic that is embedded in the Makefile into a separate script.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Good point.  Will do.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18014?tab=comments">Patch Set #1:</a> </p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">When I configure / menuselect / make on ubuntu 20.04, I get stuck here:<br>make<br>make[1]: Entering directory '/usr/src/asterisk/asterisk-16'<br>/bin/sh: 1: channels: not found</p><p style="white-space: pre-wrap; word-wrap: break-word;">If I configure / menuselect in the main branch, then switch to this change then run make, it builds.</p><p style="white-space: pre-wrap; word-wrap: break-word;">It seems .lastclean is not being created.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Hmmm.  I didn't touch that bit at all.  I'll test more.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18014">change 18014</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18014"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I486c16c0b5a44d7a8870008e10c941fb19b71ade </div>
<div style="display:none"> Gerrit-Change-Number: 18014 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 15 Feb 2022 12:01:50 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Comment-In-Reply-To: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>