<p>Friendly Automation <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/17992">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  N A: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, but someone else must approve
  Kevin Harwell: Looks good to me, approved
  Friendly Automation: Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">res_prometheus.c: missing module dependency<br><br>added res_pjsip_outbound_registration to .requires in AST_MODULE_INFO<br>which fixes issue with module crashes on load "FRACK!, Failed assertion"<br><br>ASTERISK-29871<br><br>Change-Id: Ia0f49d048427a40e1b763296b834a52a03610096<br>---<br>M configs/samples/prometheus.conf.sample<br>M res/res_prometheus.c<br>2 files changed, 7 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/configs/samples/prometheus.conf.sample b/configs/samples/prometheus.conf.sample</span><br><span>index 3ee9290..ee4a196 100644</span><br><span>--- a/configs/samples/prometheus.conf.sample</span><br><span>+++ b/configs/samples/prometheus.conf.sample</span><br><span>@@ -10,6 +10,10 @@</span><br><span> ; Because Prometheus scrapes statistics from HTTP servers, this module requires</span><br><span> ; Asterisk's built-in HTTP server to be enabled and configured properly.</span><br><span> ;</span><br><span style="color: hsl(120, 100%, 40%);">+; Module Dependencies:</span><br><span style="color: hsl(120, 100%, 40%);">+; only if Asterisk is build with pjproject bundled (default)</span><br><span style="color: hsl(120, 100%, 40%);">+; * res_pjsip.so</span><br><span style="color: hsl(120, 100%, 40%);">+; * res_pjsip_outbound_registration.so</span><br><span> </span><br><span> ; Settings that affect all statistic generation</span><br><span> [general]</span><br><span>diff --git a/res/res_prometheus.c b/res/res_prometheus.c</span><br><span>index 11b8f02..4aacf6e 100644</span><br><span>--- a/res/res_prometheus.c</span><br><span>+++ b/res/res_prometheus.c</span><br><span>@@ -27,6 +27,7 @@</span><br><span> /*** MODULEINFO</span><br><span>        <use>pjproject</use></span><br><span>     <use type="module">res_pjsip</use></span><br><span style="color: hsl(120, 100%, 40%);">+      <use type="module">res_pjsip_outbound_registration</use></span><br><span>       <support_level>extended</support_level></span><br><span>  ***/</span><br><span> </span><br><span>@@ -1002,6 +1003,7 @@</span><br><span>     .reload = reload_module,</span><br><span>     .load_pri = AST_MODPRI_DEFAULT,</span><br><span> #ifdef HAVE_PJPROJECT</span><br><span style="color: hsl(0, 100%, 40%);">-        .requires = "res_pjsip",</span><br><span style="color: hsl(120, 100%, 40%);">+    /* This module explicitly calls into res_pjsip if Asterisk is built with PJSIP support, so they are required. */</span><br><span style="color: hsl(120, 100%, 40%);">+      .requires = "res_pjsip,res_pjsip_outbound_registration",</span><br><span> #endif</span><br><span> );</span><br><span></span><br></pre><div style="white-space:pre-wrap"></div><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/17992">change 17992</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/17992"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 19 </div>
<div style="display:none"> Gerrit-Change-Id: Ia0f49d048427a40e1b763296b834a52a03610096 </div>
<div style="display:none"> Gerrit-Change-Number: 17992 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Mark Petersen <asterisk.org@zombie.dk> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-CC: Mark Petersen <bugs.digium.com@zombie.dk> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>