<p> Attention is currently required from: George Joseph. </p>
<p>George Joseph <strong>uploaded patch set #2</strong> to this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/17945">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">build: Add "basebranch" to .gitreview<br><br>If you have a development branch for a major project that<br>will receive gerrit reviews it'll probably be named something<br>like "development/16/newproject".  That will necessitate setting<br>"defaultbranch=development/16/newproject" in .gitreview.  The<br>make_version script uses that variable to construct the asterisk<br>version however, which results in versions like<br>"GIT-development/16/newproject-ee582a8c7b" which is probably not<br>what you want.  Worse, since the download_externals script uses<br>make_version to construct the URL to download the binary codecs<br>or DPMA.  Since it's expecting a simple numeric version, the<br>downloads will fail.<br><br>To get this to work, a new variable "basebranch" has been added<br>to .gitreview and make_version has been updated to use that instead<br>of defaultversion:<br><br>.gitreview:<br>defaultbranch=development/16/myproject<br>basebranch=16<br><br>Now git-review will send the reviews to the proper branch<br>(development/16/myproject) but the version will still be<br>constructed using the simple branch number (16).<br><br>If "basebranch" is missing from .gitreview, make_version will<br>fall back to using "defaultbranch".<br><br>Change-Id: I2941a3b21e668febeb6cfbc1a7bb51a67726fcc4<br>---<br>M .gitreview<br>M build_tools/make_version<br>2 files changed, 6 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/45/17945/2</pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/17945">change 17945</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/17945"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I2941a3b21e668febeb6cfbc1a7bb51a67726fcc4 </div>
<div style="display:none"> Gerrit-Change-Number: 17945 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>