<p> Attention is currently required from: Sean Bright, Kevin Harwell, Mark Murawski. </p>
<p>Patch set 5:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/17798">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File main/pbx.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17798/comment/16f88cf4_b9ccace8">Patch Set #5, Line 7305:</a> <code style="font-family:monospace,monospace"> int ret;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Indentation</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17798/comment/e49d1305_4bea0ccc">Patch Set #5, Line 7307:</a> <code style="font-family:monospace,monospace"> if (ast_mutex_trylock(&conlock)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Have you audited all of the callers of this to see how they react? What user experience/etc occurs?</p><p style="white-space: pre-wrap; word-wrap: break-word;">Have you tested this through all use cases, for example does this get used when pattern matching hints are done? Does that impact/cause locking issues? I ask because instead of locking on a per-context basis, it's now locking the known universe.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17798/comment/43a27d9c_c9c4102f">Patch Set #5, Line 7312:</a> <code style="font-family:monospace,monospace"> application, data, datad, registrar, registrar_file, registrar_line, 1);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Conlock is already held, should the last argument be 0 since the locking doesn't need to occur?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17798/comment/91ac3a06_b3f40b37">Patch Set #5, Line 7316:</a> <code style="font-family:monospace,monospace"> return ret;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Indentation</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File pbx/pbx_config.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17798/comment/f90fbe16_a1b33c95">Patch Set #5, Line 2098:</a> <code style="font-family:monospace,monospace"> /*</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This will cause PBX execution to halt during the entire I/O and processing operation for extensions.conf, which is a substantial change to behavior and can have real world implications besides fixing this issue.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Why do you have to lock this here? The ast_merge_contexts_and_delete function locks.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/17798">change 17798</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/17798"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 18 </div>
<div style="display:none"> Gerrit-Change-Id: I435db97fc56f18b6f5c25a3e400603817b07aa49 </div>
<div style="display:none"> Gerrit-Change-Number: 17798 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Mark Murawski <markm@intellasoft.net> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-CC: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Attention: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Attention: Mark Murawski <markm@intellasoft.net> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 18 Jan 2022 10:37:47 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>