<p>Benjamin Keith Ford has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/c/testsuite/+/16523">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">STIR/SHAKEN: Update config options and skip mismatch test.<br><br>The stir_shaken config option is being updated so that you can choose if<br>you want to do attestation, verification, or both. The tests need to be<br>updated for this as well.<br><br>For now, skip the mismatch test because we need a better solution than<br>bypassing the Date header to make things work as intended.<br><br>Change-Id: I9b6186dc74dc1c34637a8ea9f4be4c8bf8f8f449<br>---<br>M tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast1/pjsip.conf<br>M tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast2/pjsip.conf<br>M tests/channels/pjsip/stir_shaken/stir_shaken_mismatch/test-config.yaml<br>M tests/channels/pjsip/stir_shaken/stir_shaken_not_present/configs/ast2/pjsip.conf<br>M tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast1/pjsip.conf<br>M tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast2/pjsip.conf<br>6 files changed, 6 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/23/16523/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast1/pjsip.conf b/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast1/pjsip.conf</span><br><span>index 675fafd..393a561 100644</span><br><span>--- a/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast1/pjsip.conf</span><br><span>+++ b/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast1/pjsip.conf</span><br><span>@@ -15,7 +15,7 @@</span><br><span> transport=transport-udp</span><br><span> allow=!all,ulaw</span><br><span> callerid=1234567</span><br><span style="color: hsl(0, 100%, 40%);">-stir_shaken=yes</span><br><span style="color: hsl(120, 100%, 40%);">+stir_shaken=attest</span><br><span> </span><br><span> [aor-bob]</span><br><span> type=aor</span><br><span>diff --git a/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast2/pjsip.conf b/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast2/pjsip.conf</span><br><span>index 8b4dbb2..fcbfdcb 100644</span><br><span>--- a/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast2/pjsip.conf</span><br><span>+++ b/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast2/pjsip.conf</span><br><span>@@ -13,4 +13,4 @@</span><br><span> context=default</span><br><span> allow=!all,ulaw</span><br><span> callerid=1234567</span><br><span style="color: hsl(0, 100%, 40%);">-stir_shaken=yes</span><br><span style="color: hsl(120, 100%, 40%);">+stir_shaken=verify</span><br><span>diff --git a/tests/channels/pjsip/stir_shaken/stir_shaken_mismatch/test-config.yaml b/tests/channels/pjsip/stir_shaken/stir_shaken_mismatch/test-config.yaml</span><br><span>index ff6a57d..1d45eb7 100644</span><br><span>--- a/tests/channels/pjsip/stir_shaken/stir_shaken_mismatch/test-config.yaml</span><br><span>+++ b/tests/channels/pjsip/stir_shaken/stir_shaken_mismatch/test-config.yaml</span><br><span>@@ -1,4 +1,5 @@</span><br><span> testinfo:</span><br><span style="color: hsl(120, 100%, 40%);">+    skip: 'Skip until we have a better solution than bypassing Date header'</span><br><span>     summary:     'Tests STIR_SHAKEN_VERIFY_MISMATCH'</span><br><span>     description: |</span><br><span>         'Run one instance of Asterisk and set up an incoming call</span><br><span>diff --git a/tests/channels/pjsip/stir_shaken/stir_shaken_not_present/configs/ast2/pjsip.conf b/tests/channels/pjsip/stir_shaken/stir_shaken_not_present/configs/ast2/pjsip.conf</span><br><span>index 8b4dbb2..fcbfdcb 100644</span><br><span>--- a/tests/channels/pjsip/stir_shaken/stir_shaken_not_present/configs/ast2/pjsip.conf</span><br><span>+++ b/tests/channels/pjsip/stir_shaken/stir_shaken_not_present/configs/ast2/pjsip.conf</span><br><span>@@ -13,4 +13,4 @@</span><br><span> context=default</span><br><span> allow=!all,ulaw</span><br><span> callerid=1234567</span><br><span style="color: hsl(0, 100%, 40%);">-stir_shaken=yes</span><br><span style="color: hsl(120, 100%, 40%);">+stir_shaken=verify</span><br><span>diff --git a/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast1/pjsip.conf b/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast1/pjsip.conf</span><br><span>index 675fafd..393a561 100644</span><br><span>--- a/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast1/pjsip.conf</span><br><span>+++ b/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast1/pjsip.conf</span><br><span>@@ -15,7 +15,7 @@</span><br><span> transport=transport-udp</span><br><span> allow=!all,ulaw</span><br><span> callerid=1234567</span><br><span style="color: hsl(0, 100%, 40%);">-stir_shaken=yes</span><br><span style="color: hsl(120, 100%, 40%);">+stir_shaken=attest</span><br><span> </span><br><span> [aor-bob]</span><br><span> type=aor</span><br><span>diff --git a/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast2/pjsip.conf b/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast2/pjsip.conf</span><br><span>index 8b4dbb2..fcbfdcb 100644</span><br><span>--- a/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast2/pjsip.conf</span><br><span>+++ b/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast2/pjsip.conf</span><br><span>@@ -13,4 +13,4 @@</span><br><span> context=default</span><br><span> allow=!all,ulaw</span><br><span> callerid=1234567</span><br><span style="color: hsl(0, 100%, 40%);">-stir_shaken=yes</span><br><span style="color: hsl(120, 100%, 40%);">+stir_shaken=verify</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/testsuite/+/16523">change 16523</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/testsuite/+/16523"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: 19 </div>
<div style="display:none"> Gerrit-Change-Id: I9b6186dc74dc1c34637a8ea9f4be4c8bf8f8f449 </div>
<div style="display:none"> Gerrit-Change-Number: 16523 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>