<p>George Joseph has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/16242">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">codec_builtin.c: G729 audio gets corrupted by Asterisk due to smoother<br><br>If Asterisk gets G.729 6-byte VAD frames inbound, then at outbound Asterisk sends this G.729 stream with non-continuous timestamps.<br>This makes the audio stream not-playable at the receiver side.<br>Linphone isn't able to play such an audio - lots of disruptions are heard.<br>Also I had complains of bad audio from users which use other types of phones.<br><br>After debugging, I found this is a regression connected with RTP Smoother (main/smoother.c).<br><br>Smoother has a special code to handle G.729 VAD frames (search for AST_SMOOTHER_FLAG_G729 in smoother.c).<br><br>However, this flag is never set in Asterisk-12 and newer.<br>Previously it has been set (see Asterisk-11).<br><br>ASTERISK-29526 #close<br><br>Change-Id: I6f51ecb1a3ecd9c6d59ec5a6811a27446e17065d<br>---<br>M main/codec_builtin.c<br>1 file changed, 1 insertion(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/42/16242/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/main/codec_builtin.c b/main/codec_builtin.c</span><br><span>index c1ae685..bd69d46 100644</span><br><span>--- a/main/codec_builtin.c</span><br><span>+++ b/main/codec_builtin.c</span><br><span>@@ -457,6 +457,7 @@</span><br><span> .samples_count = g729_samples,</span><br><span> .get_length = g729_length,</span><br><span> .smooth = 1,</span><br><span style="color: hsl(120, 100%, 40%);">+ .smoother_flags = AST_SMOOTHER_FLAG_G729,</span><br><span> };</span><br><span> </span><br><span> static unsigned char get_n_bits_at(unsigned char *data, int n, int bit)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16242">change 16242</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16242"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 19 </div>
<div style="display:none"> Gerrit-Change-Id: I6f51ecb1a3ecd9c6d59ec5a6811a27446e17065d </div>
<div style="display:none"> Gerrit-Change-Number: 16242 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-CC: under <pcapdump@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>