<p> Attention is currently required from: Joshua Colp, George Joseph. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/16070">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File funcs/func_dtmfstore.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16070/comment/8a51802a_da27d2e2">Patch Set #1, Line 62:</a> <code style="font-family:monospace,monospace">=CDR(digits)</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I don't understand this example. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This dictates that any digits dialed in the specified direction will by appended to this variable. So in this case, since I want them in a CDR record (custom column), I just specify this column and when the call is over, it will automatically be there with no further processing required.<br>A non-CDR variable could be used, but I think CDR variables would be the most useful case.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16070/comment/0cdc9bcf_2392f637">Patch Set #1, Line 150:</a> <code style="font-family:monospace,monospace">ast_strdupa</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">You don't need to strdup these. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16070/comment/55da63fa_af292613">Patch Set #1, Line 152:</a> <code style="font-family:monospace,monospace">ast_strdupa</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Same</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16070/comment/4684e9df_21f9ccc5">Patch Set #1, Line 168:</a> <code style="font-family:monospace,monospace"> remove_dtmf_store(chan); /* reached max digit count, stop now */</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Do you really want to remove the store? If you do, you won't be able to get the existing digits.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">The digits go directly into the variable during the callback, so if maximum # of digits is reached (e.g., the database column only stores X digits), then we may as well get rid of this entirely at this point so it won't do anything useful for us afterwards. Destroying the framehook doesn't modify the collected digits because they are not stored as part of it, but in the specified variable.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16070">change 16070</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16070"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I51aa93fc9507f7636ac44806c4420ce690423e6f </div>
<div style="display:none"> Gerrit-Change-Number: 16070 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-CC: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 23 Jun 2021 20:49:57 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>