<p style="white-space: pre-wrap; word-wrap: break-word;">-1 for the ao2_cleanup one. Rest are optional if you decide.</p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15806">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15806/2/res/res_pjsip_messaging.c">File res/res_pjsip_messaging.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15806/2/res/res_pjsip_messaging.c@270">Patch Set #2, Line 270:</a> <code style="font-family:monospace,monospace">                            ast_debug(3, "Dest: FAIL: '%s' Found endpoint '%s' but didn't find an aor/contact for it\n",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Maybe make this an actual error message?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15806/2/res/res_pjsip_messaging.c@273">Patch Set #2, Line 273:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                                ao2_cleanup(contact);<br>                         *uri = ast_strdup(contact->uri);<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Copy the contact's uri before cleanup on the off chance cleanup frees contact.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15806/2/res/res_pjsip_messaging.c@306">Patch Set #2, Line 306:</a> <code style="font-family:monospace,monospace">                      ast_debug(3, "Dest: '%s' FAIL: Didn't find endpoint with name '%s' before the slash\n",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Similarly maybe make this log an error vs debug too?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15806/2/res/res_pjsip_messaging.c@344">Patch Set #2, Line 344:</a> <code style="font-family:monospace,monospace">                                      ast_debug(3, "Dest: '%s' FAIL: Found endpoint '%s' but didn't find contact for aor '%s'\n",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">debug to error?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15806/2/res/res_pjsip_messaging.c@391">Patch Set #2, Line 391:</a> <code style="font-family:monospace,monospace">                               ast_debug(3, "Dest: '%s' FAIL: Found endpoint '%s' but didn't find contact\n",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">make an error log?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15806">change 15806</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15806"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 18 </div>
<div style="display:none"> Gerrit-Change-Id: I67a485196d9199916468f7f98bfb9a0b993a4cce </div>
<div style="display:none"> Gerrit-Change-Number: 15806 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 28 Apr 2021 20:46:08 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>