<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15727">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15727/1/res/res_pjsip_messaging.c">File res/res_pjsip_messaging.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15727/1/res/res_pjsip_messaging.c@250">Patch Set #1, Line 250:</a> <code style="font-family:monospace,monospace">   if(domain_start) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Space before (</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15727/1/res/res_pjsip_messaging.c@251">Patch Set #1, Line 251:</a> <code style="font-family:monospace,monospace">               domain_start += 12; /* 12 is sizeof("x-to_domain") */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Just use sizeof("x-to_domain") instead of hardcoding 12.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15727/1/res/res_pjsip_messaging.c@254">Patch Set #1, Line 254:</a> <code style="font-family:monospace,monospace">              if(domain_end){</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Space before ( and before {</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15727/1/res/res_pjsip_messaging.c@256">Patch Set #1, Line 256:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                tmp_ptr = (char *)ast_malloc(domain_len + 1);<br>                 strncpy(tmp_ptr, domain_start, domain_len);<br>                   tmp_ptr[domain_len + 1]= '\0';<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Use ast_strndup (and don't cast the result). Also check to make sure it doesn't return NULL.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15727">change 15727</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15727"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 18 </div>
<div style="display:none"> Gerrit-Change-Id: Ib164d5274ffe73db15811d4decfc50e6eddcf80c </div>
<div style="display:none"> Gerrit-Change-Number: 15727 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Yang Chen <yang.chen@linuxe.org> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-CC: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 22 Apr 2021 15:11:21 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>