<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 4: Code-Review-1</p><p style="white-space: pre-wrap; word-wrap: break-word;">I'm going to mark this -1 as it is a substantial behavior change at the moment.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Agreed.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15630">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15630/4/res/res_pjsip/pjsip_message_filter.c">File res/res_pjsip/pjsip_message_filter.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15630/4/res/res_pjsip/pjsip_message_filter.c@242">Patch Set #4, Line 242:</a> <code style="font-family:monospace,monospace">   if ((tdata->tp_info.transport->key.type != PJSIP_TRANSPORT_UDP) &&</code></p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">I think at the very least the behavior should not be the default, and if it is desired it should be behind an option. Changing such behavior can have unintended consequences.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">I agree, by now I'm pretty sure it is not the desired behaviour :/</p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">As for the right direction to do this, I'm not actually sure. Using the transport itself will likely give the ephemeral port, so you'd need to get the information from the factory instead.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Thanks, I'll try to get the correct port from the transport's factory somehow.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15630">change 15630</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15630"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I598e60257a7f92b29efce1fb3e9a2fc06f1439b6 </div>
<div style="display:none"> Gerrit-Change-Number: 15630 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Florian Floimair <f.floimair@commend.com> </div>
<div style="display:none"> Gerrit-Reviewer: Bernd Zobl <b.zobl@commend.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 02 Apr 2021 09:05:07 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Comment-In-Reply-To: Bernd Zobl <b.zobl@commend.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>