<p>Joshua Colp <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15578">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Joshua Colp: Looks good to me, but someone else must approve; Approved for Submit
  George Joseph: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">strings.h: ast_str_to_upper() and _to_lower() are not pure.<br><br>Because they modify their argument they are not pure functions and<br>should not be marked as such, otherwise the compiler may optimize<br>them away.<br><br>ASTERISK-29306 #close<br><br>Change-Id: Ibec03a08522dd39e8a137ece9bc6a3059dfaad5f<br>---<br>M include/asterisk/strings.h<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/asterisk/strings.h b/include/asterisk/strings.h</span><br><span>index e9d786c..929cbf5 100644</span><br><span>--- a/include/asterisk/strings.h</span><br><span>+++ b/include/asterisk/strings.h</span><br><span>@@ -1265,7 +1265,7 @@</span><br><span>  *</span><br><span>  * \retval str for convenience</span><br><span>  */</span><br><span style="color: hsl(0, 100%, 40%);">-static force_inline char *attribute_pure ast_str_to_lower(char *str)</span><br><span style="color: hsl(120, 100%, 40%);">+static force_inline char *ast_str_to_lower(char *str)</span><br><span> {</span><br><span>   char *str_orig = str;</span><br><span>        if (!str) {</span><br><span>@@ -1286,7 +1286,7 @@</span><br><span>  *</span><br><span>  * \retval str for convenience</span><br><span>  */</span><br><span style="color: hsl(0, 100%, 40%);">-static force_inline char *attribute_pure ast_str_to_upper(char *str)</span><br><span style="color: hsl(120, 100%, 40%);">+static force_inline char *ast_str_to_upper(char *str)</span><br><span> {</span><br><span>   char *str_orig = str;</span><br><span>        if (!str) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15578">change 15578</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15578"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ibec03a08522dd39e8a137ece9bc6a3059dfaad5f </div>
<div style="display:none"> Gerrit-Change-Number: 15578 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>