<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 3:</p><p style="white-space: pre-wrap; word-wrap: break-word;">Apparently this wasn't a straight up revert, as I can't build func_callerid now:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">func_callerid.c: In function ‘redirecting_read’:<br>func_callerid.c:1489:37: error: array subscript 0 is outside the bounds of an interior zero-length array ‘char *[0]’ [-Werror=zero-length-bounds]<br> 1489 |  if (!strcasecmp("orig", member.argv[0])) {<br>      |                          ~~~~~~~~~~~^~~<br>func_callerid.c:425:53: note: while referencing ‘argv’<br>  425 | AST_DEFINE_APP_ARGS_TYPE(ast_party_members,<br>      |                                                     ^   <br>func_callerid.c:1467:27: note: defined here ‘member’<br> 1467 |  struct ast_party_members member = { 0, };<br>      |                           ^~~~~~</pre><p style="white-space: pre-wrap; word-wrap: break-word;">Along with more.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">What the hell.  Ok, the error makes sense since it's static analysis there.  May I inquire your build environment?  Happy to find a resolution for you but I need to be able to reproduce first.  And given ./configure; make; make that ain't happening.</p><p style="white-space: pre-wrap; word-wrap: break-word;">That is actually a very good analysis though, either way, I get that it's an issue, but why use member.argv[0] here instead of member.subnames[0]?  Suspect this is where the other more complicated patch was probably better.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15441">View Change</a></p><ul style="list-style: none; padding: 0;"></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15441">change 15441</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15441"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5b9f02a9b290675682a1d13f1788fdda597c9fca </div>
<div style="display:none"> Gerrit-Change-Number: 15441 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Jaco Kroon <jaco@uls.co.za> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 24 Feb 2021 14:08:35 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>