<p>Kevin Harwell <strong>uploaded patch set #2</strong> to the change originally created by Joshua Colp.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15475">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">AST-2021-002: Remote crash possible when negotiating T.38<br><br>When an endpoint requests to re-negotiate for fax and the incoming<br>re-invite is received prior to Asterisk sending out the 200 OK for<br>the initial invite the re-invite gets delayed. When Asterisk does<br>finally send the re-inivite the SDP includes streams for both audio<br>and T.38.<br><br>This happens because when the pending topology and active topologies<br>differ (pending stream is not in the active) in the delayed scenario<br>the pending stream is appended to the active topology. However, in<br>the fax case the pending stream should replace the active.<br><br>This patch makes it so when a delay occurs during fax negotiation,<br>to or from, the audio stream is replaced by the T.38 stream, or vice<br>versa instead of being appended.<br><br>Further when Asterisk sent the re-invite with both audio and T.38,<br>and the endpoint responded with a declined T.38 stream then Asterisk<br>would crash when attempting to change the T.38 state.<br><br>This patch also puts in a check that ensures the media state has a<br>valid fax session (associated udptl object) before changing the<br>T.38 state internally.<br><br>ASTERISK-29203 #close<br><br>Change-Id: I407f4fa58651255b6a9030d34fd6578cf65ccf09<br>---<br>M res/res_pjsip_session.c<br>M res/res_pjsip_t38.c<br>2 files changed, 17 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/75/15475/2</pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15475">change 15475</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15475"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 18.2 </div>
<div style="display:none"> Gerrit-Change-Id: I407f4fa58651255b6a9030d34fd6578cf65ccf09 </div>
<div style="display:none"> Gerrit-Change-Number: 15475 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>