<p>Alexander Traud has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15378">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">chan_sip: Set up calls without audio (text+video), again.<br><br>ASTERISK-29265<br><br>Change-Id: Ic16a3bf13cd1b5c4fc4041ed74961177d96b600f<br>---<br>M channels/chan_sip.c<br>1 file changed, 2 insertions(+), 12 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/78/15378/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/channels/chan_sip.c b/channels/chan_sip.c</span><br><span>index 23b22e8..e5d6cb6 100644</span><br><span>--- a/channels/chan_sip.c</span><br><span>+++ b/channels/chan_sip.c</span><br><span>@@ -30795,7 +30795,6 @@</span><br><span>    char *ext = NULL, *host;</span><br><span>     char tmp[256];</span><br><span>       struct ast_str *codec_buf = ast_str_alloca(AST_FORMAT_CAP_NAMES_LEN);</span><br><span style="color: hsl(0, 100%, 40%);">-   struct ast_str *cap_buf = ast_str_alloca(AST_FORMAT_CAP_NAMES_LEN);</span><br><span>  char *dnid;</span><br><span>  char *secret = NULL;</span><br><span>         char *md5secret = NULL;</span><br><span>@@ -30811,17 +30810,8 @@</span><br><span>           AST_APP_ARG(remote_address);</span><br><span>         );</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  /* mask request with some set of allowed formats.</span><br><span style="color: hsl(0, 100%, 40%);">-        * XXX this needs to be fixed.</span><br><span style="color: hsl(0, 100%, 40%);">-   * The original code uses AST_FORMAT_AUDIO_MASK, but it is</span><br><span style="color: hsl(0, 100%, 40%);">-       * unclear what to use here. We have global_capabilities, which is</span><br><span style="color: hsl(0, 100%, 40%);">-       * configured from sip.conf, and sip_tech.capabilities, which is</span><br><span style="color: hsl(0, 100%, 40%);">-         * hardwired to all audio formats.</span><br><span style="color: hsl(0, 100%, 40%);">-       */</span><br><span style="color: hsl(0, 100%, 40%);">-     if (!(ast_format_cap_has_type(cap, AST_MEDIA_TYPE_AUDIO))) {</span><br><span style="color: hsl(0, 100%, 40%);">-            ast_log(LOG_NOTICE, "Asked to get a channel of unsupported format %s while capability is %s\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                       ast_format_cap_get_names(cap, &codec_buf),</span><br><span style="color: hsl(0, 100%, 40%);">-                  ast_format_cap_get_names(sip_cfg.caps, &cap_buf));</span><br><span style="color: hsl(120, 100%, 40%);">+        if (ast_format_cap_empty(cap)) {</span><br><span style="color: hsl(120, 100%, 40%);">+              ast_log(LOG_NOTICE, "Asked to get a channel without offering any format\n");</span><br><span>               *cause = AST_CAUSE_BEARERCAPABILITY_NOTAVAIL;   /* Can't find codec to connect to host */</span><br><span>                return NULL;</span><br><span>         }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15378">change 15378</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15378"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 18 </div>
<div style="display:none"> Gerrit-Change-Id: Ic16a3bf13cd1b5c4fc4041ed74961177d96b600f </div>
<div style="display:none"> Gerrit-Change-Number: 15378 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Alexander Traud <pabstraud@compuserve.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>