<p> Attention is currently required from: Robert Cripps. </p>
<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15230">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_pjsip_session.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15230/comment/9c604c23_d7ccebf7">Patch Set #1, Line 500:</a> <code style="font-family:monospace,monospace">         if (session_media && session_media->type == type) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">So, if we got a session_media object but its type doesn't match, what happens to it?  I _think_ it'll leak if we then use the one from the active state.  If we don't use the one from the active state, we'll wind up using this one anyway.  See below.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15230/comment/5879f3fa_02090fce">Patch Set #1, Line 507:</a> <code style="font-family:monospace,monospace">              session_media = AST_VECTOR_GET(&session->active_media_state->sessions, position);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">If we get here, we've lost the pointer to the original one and can't free it before replacing it.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15230/comment/c087e861_e6f1d872">Patch Set #1, Line 533:</a> <code style="font-family:monospace,monospace"> if (!session_media) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">If there was an existing session_media but the type didn't match and we didn't use the active one, we won't create a new one so when we do the replace further down, we'll just be replacing the original one with itself.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15230">change 15230</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15230"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I6f6efa9b821ebe8881bb4c8c957f8802ddcb4b5d </div>
<div style="display:none"> Gerrit-Change-Number: 15230 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Robert Cripps <rcripps@voxbone.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Robert Cripps <rcripps@voxbone.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 06 Jan 2021 14:59:52 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>