<p> Attention is currently required from: Nick French. </p>
<p>Nick French would like Nick French to <strong>review</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15255">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">res_pjsip: Prevent segfault in UDP registration with flow transports<br><br>Segfault occurs during outbound UDP registration when all<br>transport states are being iterated over. The transport object<br>in the transport is accessed, but flow transports have a NULL<br>transport object.<br><br>Modify to not iterate over any flow transport<br><br>ASTERISK-29218 #close<br><br>Change-Id: If28dc3a18bdcbd0a49598b09b7fe4404d45c996a<br>---<br>M res/res_pjsip/pjsip_message_filter.c<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/55/15255/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/res/res_pjsip/pjsip_message_filter.c b/res/res_pjsip/pjsip_message_filter.c</span><br><span>index 1826ee2..7c91ba8 100644</span><br><span>--- a/res/res_pjsip/pjsip_message_filter.c</span><br><span>+++ b/res/res_pjsip/pjsip_message_filter.c</span><br><span>@@ -111,7 +111,8 @@</span><br><span>      }</span><br><span> </span><br><span>        for (iter = ao2_iterator_init(transport_states, 0); (transport_state = ao2_iterator_next(&iter)); ao2_ref(transport_state, -1)) {</span><br><span style="color: hsl(0, 100%, 40%);">-           if (transport_state->type == AST_TRANSPORT_UDP &&</span><br><span style="color: hsl(120, 100%, 40%);">+          if (!transport_state->flow &&</span><br><span style="color: hsl(120, 100%, 40%);">+                      transport_state->type == AST_TRANSPORT_UDP &&</span><br><span>                     !pj_strcmp(&transport_state->transport->local_name.host, address) &&</span><br><span>                       transport_state->transport->local_name.port == port) {</span><br><span>                         sip_transport = transport_state->transport;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15255">change 15255</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15255"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 17 </div>
<div style="display:none"> Gerrit-Change-Id: If28dc3a18bdcbd0a49598b09b7fe4404d45c996a </div>
<div style="display:none"> Gerrit-Change-Number: 15255 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nick French <naf@ou.edu> </div>
<div style="display:none"> Gerrit-Reviewer: Nick French <nickfrench@gmail.com> </div>
<div style="display:none"> Gerrit-Attention: Nick French <nickfrench@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>