<p>Patch set 11:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14729">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14729/11/include/asterisk/res_pjsip.h">File include/asterisk/res_pjsip.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14729/11/include/asterisk/res_pjsip.h@581">Patch Set #11, Line 581:</a> <code style="font-family:monospace,monospace">      /*! Do we add History-Info headers to applicable outgoing requests/responses? */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This should come at the end to preserve backwards ABI.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14729/11/res/res_pjsip_diversion.c">File res/res_pjsip_diversion.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14729/11/res/res_pjsip_diversion.c@222">Patch Set #11, Line 222:</a> <code style="font-family:monospace,monospace">          fromto_hdr =  pjsip_parse_hdr(rdata->tp_info.pool, &from_name, value.ptr,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This assumes this won't fail, but what if the contents can not be parsed as a From/To?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14729/11/res/res_pjsip_diversion.c@243">Patch Set #11, Line 243:</a> <code style="font-family:monospace,monospace">static pjsip_fromto_hdr *get_history_info_header_from(pjsip_rx_data *rdata)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This is a lot of duplicated code, can a common function be used that merely has an argument passed in to define behavior?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14729/11/res/res_pjsip_diversion.c@265">Patch Set #11, Line 265:</a> <code style="font-family:monospace,monospace">            fromto_hdr =  pjsip_parse_hdr(rdata->tp_info.pool, &from_name, value.ptr,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same here</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14729/11/res/res_pjsip_diversion.c@609">Patch Set #11, Line 609:</a> <code style="font-family:monospace,monospace">    param->name = pj_str("index");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">These should follow convention elsewhere and be static const pj_str_t, same goes for the others</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14729">change 14729</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14729"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I2296369582d4b295c5ea1e60bec391dd1d318fa6 </div>
<div style="display:none"> Gerrit-Change-Number: 14729 </div>
<div style="display:none"> Gerrit-PatchSet: 11 </div>
<div style="display:none"> Gerrit-Owner: Torrey Searle <tsearle@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 09 Sep 2020 10:36:17 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>