<p>George Joseph <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14663">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved; Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">acl.c: Coerce a NULL pointer into the empty string<br><br>If an ACL is misconfigured in the realtime database (for instance, the<br>"rule" is blank) and Asterisk attempts to read the ACL, Asterisk will<br>crash.<br><br>ASTERISK-28978 #close<br><br>Change-Id: Ic1536c4df856231bfd2da00128f7822224d77610<br>---<br>M main/acl.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/main/acl.c b/main/acl.c</span><br><span>index a560046..2a40fae 100644</span><br><span>--- a/main/acl.c</span><br><span>+++ b/main/acl.c</span><br><span>@@ -578,7 +578,7 @@</span><br><span>         struct ast_ha *ha;</span><br><span>   struct ast_ha *prev = NULL;</span><br><span>  struct ast_ha *ret;</span><br><span style="color: hsl(0, 100%, 40%);">-     char *tmp, *list = ast_strdupa(stuff);</span><br><span style="color: hsl(120, 100%, 40%);">+        char *tmp, *list = ast_strdupa(stuff ?: "");</span><br><span>       char *address = NULL, *mask = NULL;</span><br><span>  int addr_is_v4;</span><br><span>      int allowing = strncasecmp(sense, "p", 1) ? AST_SENSE_DENY : AST_SENSE_ALLOW;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14663">change 14663</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14663"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 18 </div>
<div style="display:none"> Gerrit-Change-Id: Ic1536c4df856231bfd2da00128f7822224d77610 </div>
<div style="display:none"> Gerrit-Change-Number: 14663 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>