<p><a href="https://gerrit.asterisk.org/c/asterisk/+/14451">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14451/2/include/asterisk/app.h">File include/asterisk/app.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14451/2/include/asterisk/app.h@1239">Patch Set #2, Line 1239:</a> <code style="font-family:monospace,monospace"> char *argv[sizeof(struct {arglist}) / sizeof(char)]; \</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Shouldn't this be sizeof(char*)? Each argument in arglist is defined using AST_APP_ARG() which uses […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Actually this is more than a memory issue. It's actually causing a unit test to fail. Good catch!</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14451">change 14451</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14451"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I54718496eb0c3ce5bd6d427cd279a29e8d2825f9 </div>
<div style="display:none"> Gerrit-Change-Number: 14451 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-CC: Kinsey Moore <nyphbl8d@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 02 Jun 2020 17:21:43 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Kinsey Moore <nyphbl8d@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>