<p>Joshua Colp <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14293">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Friendly Automation: Verified
Joshua Colp: Looks good to me, approved; Approved for Submit
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Revert "res_rtp_asterisk: Resolve loop when receive buffer is flushed"<br><br>This reverts commit 22bc8a71680e4099ffd3ccff7b3fe33d26291c36.<br><br>Reason for revert: Waiting for future release.<br><br>Change-Id: If924f0b7fa02a72b52c708aa80addc361a87b490<br>---<br>M res/res_rtp_asterisk.c<br>1 file changed, 0 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/res/res_rtp_asterisk.c b/res/res_rtp_asterisk.c</span><br><span>index 134eebc..6c4f408 100644</span><br><span>--- a/res/res_rtp_asterisk.c</span><br><span>+++ b/res/res_rtp_asterisk.c</span><br><span>@@ -7736,14 +7736,6 @@</span><br><span> ast_debug(2, "Inserted just received packet with sequence number '%d' in correct order on RTP instance '%p'\n",</span><br><span> seqno, instance);</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- /* It is possible due to packet retransmission for this packet to also exist in the receive</span><br><span style="color: hsl(0, 100%, 40%);">- * buffer so we explicitly remove it in case this occurs, otherwise the receive buffer will</span><br><span style="color: hsl(0, 100%, 40%);">- * never be empty.</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">- payload = (struct ast_rtp_rtcp_nack_payload *)ast_data_buffer_remove(rtp->recv_buffer, seqno);</span><br><span style="color: hsl(0, 100%, 40%);">- if (payload) {</span><br><span style="color: hsl(0, 100%, 40%);">- ast_free(payload);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span> rtp->expectedrxseqno++;</span><br><span> if (rtp->expectedrxseqno == SEQNO_CYCLE_OVER) {</span><br><span> rtp->expectedrxseqno = 0;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14293">change 14293</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14293"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: certified/16.8 </div>
<div style="display:none"> Gerrit-Change-Id: If924f0b7fa02a72b52c708aa80addc361a87b490 </div>
<div style="display:none"> Gerrit-Change-Number: 14293 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: nappsoft <infos@nappsoft.ch> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>