<p>Joshua Colp <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14109">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Joshua Colp: Looks good to me, but someone else must approve; Approved for Submit
  Kevin Harwell: Looks good to me, approved
  George Joseph: Looks good to me, but someone else must approve

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">chan_unistim: Avoid tautological warnings with clang.<br><br>ASTERISK-28803<br><br>Change-Id: I15449621b68d0ad4d57b7c337c1167adb15135af<br>---<br>M channels/chan_unistim.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/channels/chan_unistim.c b/channels/chan_unistim.c</span><br><span>index 0ed190b..99cd2d1 100644</span><br><span>--- a/channels/chan_unistim.c</span><br><span>+++ b/channels/chan_unistim.c</span><br><span>@@ -1351,7 +1351,7 @@</span><br><span> </span><br><span> static int is_key_favorite(struct unistim_device *d, int fav)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-    if ((fav < 0) && (fav > 5)) {</span><br><span style="color: hsl(120, 100%, 40%);">+   if ((fav < 0) || (fav >= FAVNUM)) {</span><br><span>            return 0;</span><br><span>    }</span><br><span>    if (d->sline[fav]) {</span><br><span>@@ -1365,7 +1365,7 @@</span><br><span> </span><br><span> static int is_key_line(struct unistim_device *d, int fav)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-   if ((fav < 0) && (fav > 5)) {</span><br><span style="color: hsl(120, 100%, 40%);">+   if ((fav < 0) || (fav >= FAVNUM)) {</span><br><span>            return 0;</span><br><span>    }</span><br><span>    if (!d->sline[fav]) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14109">change 14109</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14109"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I15449621b68d0ad4d57b7c337c1167adb15135af </div>
<div style="display:none"> Gerrit-Change-Number: 14109 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Alexander Traud <pabstraud@compuserve.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>