<p>Friendly Automation <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/testsuite/+/14018">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  George Joseph: Looks good to me, approved
  Friendly Automation: Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pjsip: Originate with audio and video for goog_remb test.<br><br>This test relies on both an audio and video stream being<br>sent in an outgoing INVITE. When placing an outgoing call<br>the requested codecs are taken into account, and by default<br>only audio is requested. We now explicitly specify the codecs<br>to use resulting in both streams.<br><br>Note that this does require a starpy update.<br><br>ASTERISK-28787<br><br>Change-Id: Ib01130454a06223bb1c9fdaaa10c3d9df22c2e5d<br>---<br>M lib/python/asterisk/pluggable_modules.py<br>M tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/test-config.yaml<br>2 files changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/lib/python/asterisk/pluggable_modules.py b/lib/python/asterisk/pluggable_modules.py</span><br><span>index dddb036..22da37e 100644</span><br><span>--- a/lib/python/asterisk/pluggable_modules.py</span><br><span>+++ b/lib/python/asterisk/pluggable_modules.py</span><br><span>@@ -53,6 +53,7 @@</span><br><span>             'async': 'False',</span><br><span>             'event': None,</span><br><span>             'timeout': None,</span><br><span style="color: hsl(120, 100%, 40%);">+            'codecs': None,</span><br><span>         }</span><br><span> </span><br><span>         # process config</span><br><span>@@ -122,6 +123,7 @@</span><br><span>                                        priority=self.config['priority'],</span><br><span>                                        timeout=self.config['timeout'],</span><br><span>                                        account=self.config['account'],</span><br><span style="color: hsl(120, 100%, 40%);">+                                       codecs=self.config['codecs'],</span><br><span>                                        async=self.config['async'])</span><br><span>         else:</span><br><span>             defer = self.ami.originate(channel=self.config['channel'],</span><br><span>@@ -129,6 +131,7 @@</span><br><span>                                        data=self.config['data'],</span><br><span>                                        timeout=self.config['timeout'],</span><br><span>                                        account=self.config['account'],</span><br><span style="color: hsl(120, 100%, 40%);">+                                       codecs=self.config['codecs'],</span><br><span>                                        async=self.config['async'])</span><br><span>         defer.addErrback(self.failure)</span><br><span> </span><br><span>diff --git a/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/test-config.yaml b/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/test-config.yaml</span><br><span>index 833ac86..f6abb5b 100644</span><br><span>--- a/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/test-config.yaml</span><br><span>+++ b/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/test-config.yaml</span><br><span>@@ -26,6 +26,7 @@</span><br><span>     context: 'default'</span><br><span>     exten: 'nowhere'</span><br><span>     priority: '1'</span><br><span style="color: hsl(120, 100%, 40%);">+    codecs: 'ulaw,vp9'</span><br><span>     trigger: 'scenario_start'</span><br><span>     scenario-name: 'reject.xml'</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/testsuite/+/14018">change 14018</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/testsuite/+/14018"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: 17 </div>
<div style="display:none"> Gerrit-Change-Id: Ib01130454a06223bb1c9fdaaa10c3d9df22c2e5d </div>
<div style="display:none"> Gerrit-Change-Number: 14018 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>