<p>sungtae kim has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14032">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">dial.c: Added AST_MAX_DIAL_ADDR constant<br><br>The dial application had a 80 character of destination length<br>limitation. But this limitation was wrong and made a problem if<br>the destination is long.<br><br>Added the proper constant and set the max length to 1024.<br><br>Change-Id: I8a419591ff22f2c82afba14f5e01f87d189e4857<br>---<br>M include/asterisk/dial.h<br>M main/dial.c<br>2 files changed, 8 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/32/14032/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/asterisk/dial.h b/include/asterisk/dial.h</span><br><span>index 168c509..0d25a1a 100644</span><br><span>--- a/include/asterisk/dial.h</span><br><span>+++ b/include/asterisk/dial.h</span><br><span>@@ -38,6 +38,12 @@</span><br><span> </span><br><span> typedef void (*ast_dial_state_callback)(struct ast_dial *);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef LOW_MEMORY</span><br><span style="color: hsl(120, 100%, 40%);">+#define AST_MAX_DIAL_ADDR     80    /*!< Max length of a destination dial address */</span><br><span style="color: hsl(120, 100%, 40%);">+#else</span><br><span style="color: hsl(120, 100%, 40%);">+#define AST_MAX_DIAL_ADDR     1024  /*!< Max length of a destination dial address */</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /*! \brief List of options that are applicable either globally or per dialed channel */</span><br><span> enum ast_dial_option {</span><br><span>  AST_DIAL_OPTION_RINGING,                 /*!< Always indicate ringing to caller */</span><br><span>diff --git a/main/dial.c b/main/dial.c</span><br><span>index d0492dc..f6cea7d 100644</span><br><span>--- a/main/dial.c</span><br><span>+++ b/main/dial.c</span><br><span>@@ -331,7 +331,7 @@</span><br><span> /*! \brief Helper function that requests all channels */</span><br><span> static int begin_dial_prerun(struct ast_dial_channel *channel, struct ast_channel *chan, struct ast_format_cap *cap, const char *predial_string)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-       char numsubst[AST_MAX_EXTENSION];</span><br><span style="color: hsl(120, 100%, 40%);">+     char numsubst[AST_MAX_DIAL_ADDR];</span><br><span>    struct ast_format_cap *cap_all_audio = NULL;</span><br><span>         struct ast_format_cap *cap_request;</span><br><span>  struct ast_format_cap *requester_cap = NULL;</span><br><span>@@ -454,7 +454,7 @@</span><br><span> /*! \brief Helper function that does the beginning dialing per-appended channel */</span><br><span> static int begin_dial_channel(struct ast_dial_channel *channel, struct ast_channel *chan, int async, const char *predial_string, struct ast_channel *forwarder_chan)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-   char numsubst[AST_MAX_EXTENSION];</span><br><span style="color: hsl(120, 100%, 40%);">+     char numsubst[AST_MAX_DIAL_ADDR];</span><br><span>    int res = 1;</span><br><span>         char forwarder[AST_CHANNEL_NAME];</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14032">change 14032</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14032"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8a419591ff22f2c82afba14f5e01f87d189e4857 </div>
<div style="display:none"> Gerrit-Change-Number: 14032 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: sungtae kim <pchero21@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>