<p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14003">View Change</a></p><p>7 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14003/3/include/asterisk/acl.h">File include/asterisk/acl.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14003/3/include/asterisk/acl.h@433">Patch Set #3, Line 433:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">#if defined(__cplusplus) || defined(c_plusplus)<br>}<br>#endif<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Shouldn't this be moved to after your new functions?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14003/3/include/asterisk/acl.h@451">Patch Set #3, Line 451:</a> <code style="font-family:monospace,monospace">void ast_ha_output(int fd, const struct ast_ha* ha, const char* prefix);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">There should be a space before the '*' for pointer types, not after.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14003/3/include/asterisk/acl.h@467">Patch Set #3, Line 467:</a> <code style="font-family:monospace,monospace">void ast_acl_output(int fd, struct ast_acl_list* acl, const char* prefix);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same as above.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14003/3/main/acl.c">File main/acl.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14003/3/main/acl.c@1087">Patch Set #3, Line 1087:</a> <code style="font-family:monospace,monospace">void ast_ha_output(int fd, const struct ast_ha* ha, const char* prefix)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Space before '*' and not after.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14003/3/main/acl.c@1099">Patch Set #3, Line 1099:</a> <code style="font-family:monospace,monospace">void ast_acl_output(int fd, struct ast_acl_list* acl_list, const char* prefix)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14003/3/main/manager.c">File main/manager.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14003/3/main/manager.c@2553">Patch Set #3, Line 2553:</a> <code style="font-family:monospace,monospace">    if (user->acl && !ast_acl_list_is_empty(user->acl))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">ast_acl_list_is_empty is NULL safe, so the first check is not necessary.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14003/3/main/manager.c@2553">Patch Set #3, Line 2553:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">if (user->acl && !ast_acl_list_is_empty(user->acl))<br>               ast_acl_output(a->fd, user->acl, NULL);<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should have braces</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14003">change 14003</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14003"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0ec9876a90dddd379c80ec078d48e3ee6991eb0f </div>
<div style="display:none"> Gerrit-Change-Number: 14003 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Jaco Kroon <jaco@uls.co.za> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 26 Mar 2020 13:22:26 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>