<p>Patch set 4:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13673">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13673/4/configure.ac">File configure.ac:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13673/4/configure.ac@2442">Patch Set #4, Line 2442:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><br>      AC_MSG_CHECKING(for pjproject on_valid_pair callback)<br>      AC_LINK_IFELSE(<br>         [AC_LANG_PROGRAM(<br>            [#include <pjsip.h><br>            #include <pjsip_ua.h><br>            #include <pjnath.h><br>            void on_valid_pair(pj_ice_sess *ice) {}<br>            void on_ice_complete(pj_ice_sess *ice, pj_status_t status) {}<br>            void on_rx_data(pj_ice_sess *ice, unsigned comp_id, unsigned transport_id, void *pkt, pj_size_t size, const pj_sockaddr_t *src_addr, unsigned src_addr_len) {}<br>            pj_status_t on_tx_pkt(pj_ice_sess *ice, unsigned comp_id, unsigned transport_id, const void *pkt, pj_size_t size, const pj_sockaddr_t *dst_addr, unsigned dst_addr_len) {}],<br>            [pj_ice_sess_cb ice_sess_cb = {<br>            .on_valid_pair = on_valid_pair,<br>            .on_ice_complete = on_ice_complete,<br>            .on_rx_data = on_rx_data,<br>            .on_tx_pkt = on_tx_pkt,<br>         };])],<br>      AC_MSG_RESULT(yes)<br>      AC_DEFINE(HAVE_PJPROJECT_ON_VALID_PAIR, 1, [Define to 1 if on_valid_pair callback is present.]),<br>      AC_MSG_RESULT(no)<br>   )<br>   fi<br><br>fi<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Do we not already, or is there no way to get the pjproject version number and use that instead?</p><p style="white-space: pre-wrap; word-wrap: break-word;">If we used the version number moving forward we would not have to keep adding in these "special" checks, but could just use the version number. Plus then looking in the code we'd know exactly what version the stuff was added in.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I can see advantages for both (the way you have it here, and just using the version number), but I think I lean toward using the version number if it's easily obtainable.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13673">change 13673</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13673"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: Ia7b68c34f06d2a1d91c5ed51627b66fd0363d867 </div>
<div style="display:none"> Gerrit-Change-Number: 13673 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 07 Feb 2020 15:36:18 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>