<p>Friendly Automation <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13755">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  Kevin Harwell: Looks good to me, approved
  Friendly Automation: Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">res_rtp_asterisk: Don't produce transport-cc if no packets.<br><br>The code assumed that when the transport-cc feedback<br>function was called at least one packet will have been<br>received. In practice this isn't always true, so now<br>we just reschedule the sending and do nothing.<br><br>Change-Id: Iabe7b358704da446fc3b0596b847bff8b8a0da6a<br>---<br>M res/res_rtp_asterisk.c<br>1 file changed, 6 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/res/res_rtp_asterisk.c b/res/res_rtp_asterisk.c</span><br><span>index 916a616..b4528f1 100644</span><br><span>--- a/res/res_rtp_asterisk.c</span><br><span>+++ b/res/res_rtp_asterisk.c</span><br><span>@@ -6667,6 +6667,12 @@</span><br><span> </span><br><span>         ao2_lock(instance);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+       /* If no packets have been received then do nothing */</span><br><span style="color: hsl(120, 100%, 40%);">+        if (!AST_VECTOR_SIZE(&rtp->transport_wide_cc.packet_statistics)) {</span><br><span style="color: hsl(120, 100%, 40%);">+             ao2_unlock(instance);</span><br><span style="color: hsl(120, 100%, 40%);">+         return 1000;</span><br><span style="color: hsl(120, 100%, 40%);">+  }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  rtcpheader = (unsigned char *)bdata;</span><br><span> </span><br><span>     /* The first packet in the vector acts as our base sequence number and reference time */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13755">change 13755</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13755"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 17 </div>
<div style="display:none"> Gerrit-Change-Id: Iabe7b358704da446fc3b0596b847bff8b8a0da6a </div>
<div style="display:none"> Gerrit-Change-Number: 13755 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>