<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 4: Code-Review-1</p><p style="white-space: pre-wrap; word-wrap: break-word;">(1 comment)</p><p style="white-space: pre-wrap; word-wrap: break-word;">Since there's already an "ast_sockaddr_copy_sockaddr" can ast_sockaddr_from_sockaddr just be a #DEFINE that wraps the existing function?</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Since that function doesn't exist in 13:</p><p style="white-space: pre-wrap; word-wrap: break-word;">jkroon@plastiekpoot ~/projects/asterisk ((HEAD detached at origin/13)) $ grep -r ast_sockaddr_copy_sockaddr .<br>[1] jkroon@plastiekpoot ~/projects/asterisk ((HEAD detached at origin/13)) $ </p><p style="white-space: pre-wrap; word-wrap: break-word;">jkroon@plastiekpoot ~/projects/asterisk (master) $ grep -r ast_sockaddr_copy_sockaddr .<br>./include/asterisk/netsock2.h:static inline void ast_sockaddr_copy_sockaddr(struct ast_sockaddr *dst,<br>./main/io.c: ast_sockaddr_copy_sockaddr(&fd_addr, &ss, ss_len);<br>jkroon@plastiekpoot ~/projects/asterisk (master) $ </p><p style="white-space: pre-wrap; word-wrap: break-word;">Perhaps I should rather just back-port that existing function?</p><p style="white-space: pre-wrap; word-wrap: break-word;">I mean really, s/copy/from/ ... for all practical purposes.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13361">View Change</a></p><ul style="list-style: none; padding: 0;"></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13361">change 13361</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13361"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: Iee604e96e9096c79b477d6e5ff310cf0b06dae86 </div>
<div style="display:none"> Gerrit-Change-Number: 13361 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Jaco Kroon <jaco@uls.co.za> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua C. Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 19 Dec 2019 09:38:17 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>