<p><a href="https://gerrit.asterisk.org/c/asterisk/+/13309">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13309/4/res/res_rtp_asterisk.c">File res/res_rtp_asterisk.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13309/4/res/res_rtp_asterisk.c@2987">Patch Set #4, Line 2987:</a> <code style="font-family:monospace,monospace"> if ((val = ast_variable_retrieve(cfg, section, opt))) {</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">There can be multiple acl/deny/permit/blacklist specified, doesn't this fail under that scenario by […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'll investigate but I believe you may be right.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13309/4/res/res_rtp_asterisk.c@2994">Patch Set #4, Line 2994:</a> <code style="font-family:monospace,monospace"> if (acl_subscription_flag && !acl_change_sub) {</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">If no ACLs are configured does it make sense to not have this subscription occur?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">int acl_subscription_flag = 0;</p><p style="white-space: pre-wrap; word-wrap: break-word;">This flag will only be set by ast_append_acl if it believes we should subscribe (ie, we're referencing a named ACL). So I believe this code is correct.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13309/4/res/res_rtp_asterisk.c@6898">Patch Set #4, Line 6898:</a> <code style="font-family:monospace,monospace"> rtp_reload(1, 1);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Can't you just call rtp_load_acl for each?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This mechanism was cloned from elsewhere (Think manager.c but I'm not certain). Basically, if rtp.conf changes the reload will happen. If a named ACL changes, we don't have a reference on which names we're supposed to be referencing.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Ideally actually I'd like this entire subscribe to not be required, in that if a named ACL is referenced, the ACL infrastructure itself would be aware of that, and update the referencing parties by implication. Should I perhaps investigate if that would be possible?</p><p style="white-space: pre-wrap; word-wrap: break-word;">As an aside since this would be related, is the aim of acl to match most-specific match, or last match?</p><p style="white-space: pre-wrap; word-wrap: break-word;">Eg:</p><p style="white-space: pre-wrap; word-wrap: break-word;">permit = 1.2.3.4/32<br>deny = 0.0.0.0/0</p><p style="white-space: pre-wrap; word-wrap: break-word;">Should 1.2.3.4 be permitted or denied?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13309">change 13309</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13309"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: Id57a8df51fcfd3bd85ea67c489c85c6c3ecd7b30 </div>
<div style="display:none"> Gerrit-Change-Number: 13309 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Jaco Kroon <jaco@uls.co.za> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua C. Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 12 Dec 2019 09:52:21 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Joshua C. Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>