<p>Friendly Automation <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13357">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Friendly Automation: Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">res_pjsip_registrar.c: Prevent possible buffer overflow with domain aliases<br><br>We're appropriately sizing the id_domain_alias buffer, but then copying the data<br>into the id_domain one. We were then using the uninitialized id_domain_alias<br>buffer we just allocated.<br><br>This is ASTERISK~28641 adjacent, but significant enough to warrant its own<br>patch.<br><br>Change-Id: I81c38724d18deab8c6573153e2b99dbb6e2f33d9<br>---<br>M res/res_pjsip_registrar.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/res/res_pjsip_registrar.c b/res/res_pjsip_registrar.c</span><br><span>index 62b738a..953be20 100644</span><br><span>--- a/res/res_pjsip_registrar.c</span><br><span>+++ b/res/res_pjsip_registrar.c</span><br><span>@@ -975,7 +975,7 @@</span><br><span>  if (alias) {</span><br><span>                 char *id_domain_alias = ast_alloca(strlen(username) + strlen(alias->domain) + 2);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-                sprintf(id_domain, "%s@%s", username, alias->domain);</span><br><span style="color: hsl(120, 100%, 40%);">+            sprintf(id_domain_alias, "%s@%s", username, alias->domain);</span><br><span>             ao2_cleanup(alias);</span><br><span> </span><br><span>              configured_aors = strcpy(aors_buf, aors);/* Safe */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13357">change 13357</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13357"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 17 </div>
<div style="display:none"> Gerrit-Change-Id: I81c38724d18deab8c6573153e2b99dbb6e2f33d9 </div>
<div style="display:none"> Gerrit-Change-Number: 13357 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>