<p>Friendly Automation <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/testsuite/+/13388">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Friendly Automation: Looks good to me, approved; Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pjsip/info_dtmf:  Add pauses in scenarios to make tests more reliable<br><br>Added a 1000ms pause before sending the first digit and a 5000ms<br>pause after sending the last one.  The last one is most important<br>because sending SIP INFO packets in quick succession can cause<br>them to get deferred which would extend the time to process them all<br>to be after we sent a BYE.  In this case the test will fail because<br>all the DTMFEnd events wouldn't have arrived before the test ended.<br><br>Change-Id: Ie86fdceabf20bdec9fc1a38a79a3523ef778f8eb<br>---<br>M tests/channels/pjsip/info_dtmf/sipp/dtmf-duration.xml<br>M tests/channels/pjsip/info_dtmf/sipp/dtmf.xml<br>2 files changed, 6 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/channels/pjsip/info_dtmf/sipp/dtmf-duration.xml b/tests/channels/pjsip/info_dtmf/sipp/dtmf-duration.xml</span><br><span>index ec64c0d..ad938f9 100644</span><br><span>--- a/tests/channels/pjsip/info_dtmf/sipp/dtmf-duration.xml</span><br><span>+++ b/tests/channels/pjsip/info_dtmf/sipp/dtmf-duration.xml</span><br><span>@@ -68,6 +68,8 @@</span><br><span>   <recv response="200" crlf="true"></span><br><span>   </recv></span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+  <pause milliseconds="1000"/></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>   <send retrans="500"></span><br><span>     <![CDATA[</span><br><span>       INFO sip:test2@[remote_ip]:[remote_port] SIP/2.0</span><br><span>@@ -383,7 +385,7 @@</span><br><span>   <recv response="200" crlf="true"></span><br><span>   </recv></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  <pause/></span><br><span style="color: hsl(120, 100%, 40%);">+  <pause milliseconds="5000"/></span><br><span> </span><br><span>   <send retrans="500"></span><br><span>     <![CDATA[</span><br><span>diff --git a/tests/channels/pjsip/info_dtmf/sipp/dtmf.xml b/tests/channels/pjsip/info_dtmf/sipp/dtmf.xml</span><br><span>index 59a6e85..f0a9aae 100644</span><br><span>--- a/tests/channels/pjsip/info_dtmf/sipp/dtmf.xml</span><br><span>+++ b/tests/channels/pjsip/info_dtmf/sipp/dtmf.xml</span><br><span>@@ -47,6 +47,8 @@</span><br><span>     ]]></span><br><span>   </send></span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+  <pause milliseconds="1000"/></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>   <send retrans="500"></span><br><span>     <![CDATA[</span><br><span>       INFO sip:test@[remote_ip]:[remote_port] SIP/2.0</span><br><span>@@ -367,7 +369,7 @@</span><br><span>   <recv response="200" crlf="true"></span><br><span>   </recv></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  <pause/></span><br><span style="color: hsl(120, 100%, 40%);">+  <pause milliseconds="5000"/></span><br><span> </span><br><span>   <send retrans="500"></span><br><span>     <![CDATA[</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/testsuite/+/13388">change 13388</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/testsuite/+/13388"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie86fdceabf20bdec9fc1a38a79a3523ef778f8eb </div>
<div style="display:none"> Gerrit-Change-Number: 13388 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-MessageType: merged </div>