<p><a href="https://gerrit.asterisk.org/c/asterisk/+/4012">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/4012/2/contrib/ast-db-manage/queue_log/versions/4105ee839f58_create_queue_log_table.py">File contrib/ast-db-manage/queue_log/versions/4105ee839f58_create_queue_log_table.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/4012/2/contrib/ast-db-manage/queue_log/versions/4105ee839f58_create_queue_log_table.py@21">Patch Set #2, Line 21:</a> <code style="font-family:monospace,monospace">        'queue_log',</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Why not to use a multi column unique index between time + queuename? […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">As long as the time value is granular enough to ensure two records are not written for the same queuename at the same time then a primary key using those two columns would work.</p><p style="white-space: pre-wrap; word-wrap: break-word;">However, I am not sure that would be the case, and it would certainly depend on the various database backends. So I'm thinking that is not the way to go.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Having a primary key helps in indexing, thus searching. I guess it's not officially required. I was always under the impression though it was something usually good to have.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't know. Think it's worth adding one? If so you can add one to the CDR table as well if you feel inclined, but since that one is already established I'd say you don't have to worry about it.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/4012">change 4012</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/4012"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I35b928a6251f9da9a1742b2cd14c63a00c3d0f0c </div>
<div style="display:none"> Gerrit-Change-Number: 4012 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Rodrigo Ramirez Norambuena <a@rodrigoramirez.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Mark Michelson <mmichelson@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Name of user not set #1000019 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Rodrigo Ramirez Norambuena <a@rodrigoramirez.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 20 Nov 2019 17:43:18 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Comment-In-Reply-To: Rodrigo Ramirez Norambuena <a@rodrigoramirez.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>