<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13173">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13173/1/res/parking/parking_bridge.c">File res/parking/parking_bridge.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13173/1/res/parking/parking_bridge.c@266">Patch Set #1, Line 266:</a> <code style="font-family:monospace,monospace">  parker = ast_channel_snapshot_get_latest(park_datastore->parker_uuid);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I forget, can get_latest return a snapshot for a channel that doesn't exist anymore?  If it does,  is the snapshot still useful for this situation?  Since all we ever use out of parker is the name, and we compare it to bridge_channel->chan, could we just compare park_datastore->parker_uuid to <br>bridge_channel->chan's uuid?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13173/1/res/parking/parking_bridge.c@285">Patch Set #1, Line 285:</a> <code style="font-family:monospace,monospace">parker</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Any reason to not just pass parker->name since that's all that's used by the other functions?  You can also get rid of the RAII for parker if you just do an ao2_cleanup right after this call before the test for pu.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13173">change 13173</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13173"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: I68ceb1d62c7378addcd286e21be08a660a7cecf2 </div>
<div style="display:none"> Gerrit-Change-Number: 13173 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 12 Nov 2019 16:56:35 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>