<p>Kevin Harwell <strong>uploaded patch set #4</strong> to this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13102">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">various files - fix some alerts raised by lgtm code analysis<br><br>This patch fixes several issues reported by the lgtm code analysis tool:<br><br>https://lgtm.com/projects/g/asterisk/asterisk<br><br>Not all reported issues were addressed in this patch. This patch mostly fixes<br>confirmed reported errors, potential problematic code points, and a few other<br>"low hanging" warnings or recommendations found in core supported modules.<br>These include, but are not limited to the following:<br><br>* innapropriate stack allocation in loops<br>* buffer overflows<br>* variable declaration "hiding" another variable declaration<br>* comparisons results that are always the same<br>* ambiguously signed bit-field members<br>* missing header guards<br><br>Change-Id: Id4a881686605d26c94ab5409bc70fcc21efacc25<br>---<br>M apps/app_cdr.c<br>M apps/app_dictate.c<br>M apps/app_followme.c<br>M apps/app_minivm.c<br>M apps/app_playback.c<br>M apps/app_readexten.c<br>M apps/app_voicemail.c<br>M channels/chan_dahdi.c<br>M channels/chan_dahdi.h<br>M channels/chan_motif.c<br>M codecs/ex_alaw.h<br>M codecs/ex_g722.h<br>M codecs/ex_ulaw.h<br>M formats/format_g726.c<br>M formats/msgsm.h<br>M include/asterisk/ari.h<br>M include/asterisk/calendar.h<br>M include/asterisk/channel_internal.h<br>M include/asterisk/config_options.h<br>M include/asterisk/max_forwards.h<br>M include/asterisk/mixmonitor.h<br>M include/asterisk/parking.h<br>M include/asterisk/res_pjsip_presence_xml.h<br>M include/asterisk/slin.h<br>M main/app.c<br>M main/asterisk.c<br>M main/event.c<br>M main/file.c<br>M main/indications.c<br>M main/manager.c<br>M main/pbx_variables.c<br>M main/stasis.c<br>M main/stasis_cache.c<br>M res/ari/config.c<br>M res/parking/parking_bridge_features.c<br>M res/parking/res_parking.h<br>M res/res_config_curl.c<br>M res/res_phoneprov.c<br>M res/res_pjsip/config_system.c<br>M res/res_pjsip/config_transport.c<br>M res/res_pjsip_endpoint_identifier_ip.c<br>M res/res_pjsip_registrar.c<br>M res/res_rtp_asterisk.c<br>M res/stasis/command.c<br>M res/stasis/control.c<br>45 files changed, 311 insertions(+), 195 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/02/13102/4</pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13102">change 13102</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13102"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: Id4a881686605d26c94ab5409bc70fcc21efacc25 </div>
<div style="display:none"> Gerrit-Change-Number: 13102 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-CC: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>