<p>Benjamin Keith Ford <strong>uploaded patch set #7</strong> to this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/12813">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">res_rtp: Add unit tests for RTCP stats.<br><br>Added unit tests for RTCP video stats. These tests include NACK, REMB,<br>FIR/FUR/PLI, SR/RR/SDES, and packet loss statistics. The REMB and FIR<br>tests are currently disabled due to a bug. We expect to receive a<br>compound packet, but the code sends this out as a single packet, which<br>the browser accepts, but makes Asterisk upset.<br><br>While writing these tests, I noticed an issue with NACK as well. Where<br>it is handling a received NACK request, it was reading in only the first<br>8 bits of following packets that were also lost. This has been changed<br>to the correct value of 16 bits.<br><br>Also made a minor fix to the data buffer unit test.<br><br>Change-Id: I56107c7411003a247589bbb6086d25c54719901b<br>---<br>M include/asterisk/rtp_engine.h<br>M main/rtp_engine.c<br>M res/res_rtp_asterisk.c<br>M tests/test_data_buffer.c<br>A tests/test_res_rtp.c<br>5 files changed, 831 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/13/12813/7</pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/12813">change 12813</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/12813"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I56107c7411003a247589bbb6086d25c54719901b </div>
<div style="display:none"> Gerrit-Change-Number: 12813 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>