<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">(2 comments)</p><p style="white-space: pre-wrap; word-wrap: break-word;">The create_mwi_subscriptions function removes all unsolicited MWI<br>subscriptions and then recreates them. I think this would cause<br>unsolicited to start again when a reload occurs.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">I don't think so. Next time an unsolicited gets created, function endpoint_receives_unsolicited_mwi_for_mailbox() will verify with pjsip.conf and will set mwi_sub->is_subscribe_replaces_unsolicited to back to true.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/11628">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/11628/1/res/res_pjsip_mwi.c">File res/res_pjsip_mwi.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11628/1/res/res_pjsip_mwi.c@684">Patch Set #1, Line 684:</a> <code style="font-family:monospace,monospace">               struct ast_sip_endpoint *endpoint = ast_sip_subscription_get_endpoint(sub->sip_sub);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Does this check actually need to be done on the endpoint? If the above field is set, then the endpoi […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">You are right.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11628">change 11628</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/11628"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: I8f77c33b9b4d374d510aa5ecd4f700a77107d8d4 </div>
<div style="display:none"> Gerrit-Change-Number: 11628 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Christian Savinovich <csavinovich@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Christian Savinovich <csavinovich@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 26 Jul 2019 21:12:00 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>