<p>Oron Peled would like Tzafrir Cohen to <strong>review</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/11533">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">openr2(1/6): bugfix in configuration saving<br><br>Details:<br>  - The memcpy() call copied part of "dahdi_conf" and not "dahdi_conf.mfcr2"<br>  - As a result, the memcmp() in dahdi_r2_get_link() always fails<br>  - This cause dahdi_r2_get_link() to create new link for every channel<br>    (instead of a new link for every ~30 channels)<br>  - With the fix, far less links are generated -- so we use far less threads<br><br>Change-Id: I7259dd6272f5e46e8a6c7f5bf3e8c2ec01b8c132<br>Signed-off-by: Oron Peled <oron.peled@xorcom.com><br>---<br>M channels/chan_dahdi.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/33/11533/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/channels/chan_dahdi.c b/channels/chan_dahdi.c</span><br><span>index 1f83f02..fb63307 100644</span><br><span>--- a/channels/chan_dahdi.c</span><br><span>+++ b/channels/chan_dahdi.c</span><br><span>@@ -11992,7 +11992,7 @@</span><br><span>          }</span><br><span>    }</span><br><span>    /* Save the configuration used to setup this link */</span><br><span style="color: hsl(0, 100%, 40%);">-    memcpy(&r2_link->conf, conf, sizeof(r2_link->conf));</span><br><span style="color: hsl(120, 100%, 40%);">+        memcpy(&r2_link->conf, &conf->mfcr2, sizeof(r2_link->conf));</span><br><span>        return 0;</span><br><span> }</span><br><span> #endif</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11533">change 11533</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/11533"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: I7259dd6272f5e46e8a6c7f5bf3e8c2ec01b8c132 </div>
<div style="display:none"> Gerrit-Change-Number: 11533 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Oron Peled <oron.peled@xorcom.com> </div>
<div style="display:none"> Gerrit-Reviewer: Tzafrir Cohen <tzafrir.cohen@xorcom.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>