<p>Friendly Automation <strong>merged</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/11473">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Kevin Harwell: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Friendly Automation: Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">translate.c do not log WARNING on empty audio frame<br><br>There is WARNING "no samples for ..." on each Playtones.<br>The function ast_playtones_start calls ast_activate_generator,<br>which calls ast_prod.<br>The function ast_prod calls ast_write with empty audio frame.<br>In this case it's spam log.<br><br>Change-Id: Id4ac309489d9ff281bad02abdef341cecdede660<br>---<br>M main/translate.c<br>1 file changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/main/translate.c b/main/translate.c</span><br><span>index 26f9c9b..fe46460 100644</span><br><span>--- a/main/translate.c</span><br><span>+++ b/main/translate.c</span><br><span>@@ -402,7 +402,10 @@</span><br><span>       pvt->f.seqno = f->seqno;</span><br><span> </span><br><span>   if (f->samples == 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-               ast_log(LOG_WARNING, "no samples for %s\n", pvt->t->name);</span><br><span style="color: hsl(120, 100%, 40%);">+            /* Do not log empty audio frame */</span><br><span style="color: hsl(120, 100%, 40%);">+            if (strcasecmp(f->src, "ast_prod")) {</span><br><span style="color: hsl(120, 100%, 40%);">+                    ast_log(LOG_WARNING, "no samples for %s\n", pvt->t->name);</span><br><span style="color: hsl(120, 100%, 40%);">+            }</span><br><span>    }</span><br><span>    if (pvt->t->buffer_samples) {     /* do not pass empty frames to callback */</span><br><span>           if (f->datalen == 0) { /* perform native PLC if available */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11473">change 11473</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/11473"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: Id4ac309489d9ff281bad02abdef341cecdede660 </div>
<div style="display:none"> Gerrit-Change-Number: 11473 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>