<p><a href="https://gerrit.asterisk.org/c/asterisk/+/11150">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/11150/1/include/asterisk/vector.h">File include/asterisk/vector.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11150/1/include/asterisk/vector.h@604">Patch Set #1, Line 604:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                   size_t new_max = (vec)->current;                             \<br>                     typeof((vec)->elems) new_elems = ast_calloc(1,               \<br>                             new_max * sizeof(*new_elems));                                  \<br>                     if (new_elems) {                                                                        \<br>                             if ((vec)->elems) {                                                          \<br>                                     memcpy(new_elems, (vec)->elems,                              \<br>                                             (vec)->current * sizeof(*new_elems));        \<br>                                     ast_free((vec)->elems);                                              \<br>                             }                                                                                               \<br>                             (vec)->elems = new_elems;                                            \<br>                             (vec)->max = new_max;                                                        \<br>                     } else {                                                                                        \<br>                             res = -1;                                                                               \<br>                             break;                                                                                  \<br>                     }                                                                                                       \<br>             }                       <br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Can you just use realloc here instead? Best case scenario the rest gets marked as usuable by malloc  […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11150">change 11150</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/11150"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: I9711daa0fe01783fc6f04c5710eba84f2676d7b9 </div>
<div style="display:none"> Gerrit-Change-Number: 11150 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 15 Mar 2019 18:24:17 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>